NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitaa698d7

committed

pg_trgm's set_limit() now uses SetConfigOption()

Deprecated set_limit() is modified to use SetConfigOption() to setsimilarity_threshold which is actually an instance ofpg_trgm.similarity_threshold GUC variable. Previous coding directly setssimilarity_threshold what could cause an inconsistency between states ofactual variable and GUC representation.Per gripe from Tom Lane

1 parent696684d commitaa698d7Copy full SHA for aa698d7

File tree

1 file changed

+11

-5

lines changed

contrib/pg_trgm
- trgm_op.c

1 file changed

+11

-5

lines changed

`‎contrib/pg_trgm/trgm_op.c`

Lines changed: 11 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`
`10`	`10`	`#include"catalog/pg_type.h"`
`11`	`11`	`#include"tsearch/ts_locale.h"`
	`12`	`+#include"utils/lsyscache.h"`
`12`	`13`	`#include"utils/memutils.h"`
`13`	`14`	`#include"utils/pg_crc.h"`
`14`	`15`
`@@ -80,12 +81,17 @@ Datum`
`80`	`81`	`set_limit(PG_FUNCTION_ARGS)`
`81`	`82`	`{`
`82`	`83`	`float4nlimit=PG_GETARG_FLOAT4(0);`
	`84`	`+char*nlimit_str;`
	`85`	`+Oidfunc_out_oid;`
	`86`	`+boolis_varlena;`
	`87`	`+`
	`88`	`+getTypeOutputInfo(FLOAT4OID,&func_out_oid,&is_varlena);`
	`89`	`+`
	`90`	`+nlimit_str=OidOutputFunctionCall(func_out_oid,Float4GetDatum(nlimit));`
	`91`	`+`
	`92`	`+SetConfigOption("pg_trgm.similarity_threshold",nlimit_str,`
	`93`	`+PGC_USERSET,PGC_S_SESSION);`
`83`	`94`
`84`		`-if (nlimit<0\|\|nlimit>1.0)`
`85`		`-ereport(ERROR,`
`86`		`-(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),`
`87`		`-errmsg("wrong threshold, should be between 0 and 1")));`
`88`		`-similarity_threshold=nlimit;`
`89`	`95`	`PG_RETURN_FLOAT4(similarity_threshold);`
`90`	`96`	`}`
`91`	`97`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaa698d7

File tree

1 file changed

1 file changed

`‎contrib/pg_trgm/trgm_op.c`

0 commit comments