NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitaa02864

committed

Must check indisready not just indisvalid when dumping from 9.2 server.

9.2 uses a kluge representation of "indislive"; we have to account forthat when examining pg_index. Simplest solution is to check indisreadyfor 9.0 and 9.1 as well; that's harmless though unnecessary, so it'snot worth making a version distinction for.Fixes oversight in commit683abc7,as noted by Andres Freund.

1 parent29505a8 commitaa02864Copy full SHA for aa02864

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4901,6 +4901,10 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4901`	`4901`	`resetPQExpBuffer(query);`
`4902`	`4902`	`if (fout->remoteVersion >=90000)`
`4903`	`4903`	`{`
	`4904`	`+/*`
	`4905`	`+ * the test on indisready is necessary in 9.2, and harmless in`
	`4906`	`+ * earlier/later versions`
	`4907`	`+ */`
`4904`	`4908`	`appendPQExpBuffer(query,`
`4905`	`4909`	`"SELECT t.tableoid, t.oid, "`
`4906`	`4910`	`"t.relname AS indexname, "`
`@@ -4922,7 +4926,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4922`	`4926`	`"i.indexrelid = c.conindid AND "`
`4923`	`4927`	`"c.contype IN ('p','u','x')) "`
`4924`	`4928`	`"WHERE i.indrelid = '%u'::pg_catalog.oid "`
`4925`		`-"AND i.indisvalid "`
	`4929`	`+"AND i.indisvalidAND i.indisready"`
`4926`	`4930`	`"ORDER BY indexname",`
`4927`	`4931`	`tbinfo->dobj.catId.oid);`
`4928`	`4932`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaa02864

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments