NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita9c074b

committed

Silence unused variable compiler warning

Fallout fromfcec6ca: mark a variable inset_tablefunc_size_estimates as used for asserts only.Also, the planner_rte_fetch() call is pointless with assertionsdisabled, so enclose it in a USE_ASSERT_CHECKING #ifdef; fix the sameproblem in set_subquery_size_estimates().First problem noted by David Rowley, whose compiler is noisier than minein this regard.

1 parent895e36b commita9c074bCopy full SHA for a9c074b

File tree

1 file changed

-1

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4458,8 +4458,10 @@ set_subquery_size_estimates(PlannerInfo root, RelOptInfo rel)`
`4458`	`4458`
`4459`	`4459`	`/* Should only be applied to base relations that are subqueries */`
`4460`	`4460`	`Assert(rel->relid>0);`
	`4461`	`+#ifdefUSE_ASSERT_CHECKING`
`4461`	`4462`	`rte=planner_rt_fetch(rel->relid,root);`
`4462`	`4463`	`Assert(rte->rtekind==RTE_SUBQUERY);`
	`4464`	`+#endif`
`4463`	`4465`
`4464`	`4466`	`/*`
`4465`	`4467`	`* Copy raw number of output rows from subquery. All of its paths should`
`@@ -4571,12 +4573,14 @@ set_function_size_estimates(PlannerInfo root, RelOptInfo rel)`
`4571`	`4573`	`void`
`4572`	`4574`	`set_tablefunc_size_estimates(PlannerInforoot,RelOptInforel)`
`4573`	`4575`	`{`
`4574`		`-RangeTblEntry*rte;`
	`4576`	`+RangeTblEntry*rtePG_USED_FOR_ASSERTS_ONLY;`
`4575`	`4577`
`4576`	`4578`	`/* Should only be applied to base relations that are functions */`
`4577`	`4579`	`Assert(rel->relid>0);`
	`4580`	`+#ifdefUSE_ASSERT_CHECKING`
`4578`	`4581`	`rte=planner_rt_fetch(rel->relid,root);`
`4579`	`4582`	`Assert(rte->rtekind==RTE_TABLEFUNC);`
	`4583`	`+#endif`
`4580`	`4584`
`4581`	`4585`	`rel->tuples=100;`
`4582`	`4586`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita9c074b

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments