Commita959c67

committed

ProcessIncomingNotify *must* reset notifyInterruptOccurred when called.

This was broken in 9.0 by careless addition of an early-exit path.Bug report and diagnosis by Jeff Davis.

1 parent660fbec commita959c67Copy full SHA for a959c67

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2090,7 +2090,10 @@ ProcessIncomingNotify(void)`
`2090`	`2090`	`{`
`2091`	`2091`	`boolcatchup_enabled;`
`2092`	`2092`
`2093`		`-/* Do nothing if we aren't actively listening */`
	`2093`	`+/* We must reset the flag */`
	`2094`	`+notifyInterruptOccurred=0;`
	`2095`	`+`
	`2096`	`+/* Do nothing else if we aren't actively listening */`
`2094`	`2097`	`if (listenChannels==NIL)`
`2095`	`2098`	`return;`
`2096`	`2099`
`@@ -2102,8 +2105,6 @@ ProcessIncomingNotify(void)`
`2102`	`2105`
`2103`	`2106`	`set_ps_display("notify interrupt", false);`
`2104`	`2107`
`2105`		`-notifyInterruptOccurred=0;`
`2106`		`-`
`2107`	`2108`	`/*`
`2108`	`2109`	`* We must run asyncQueueReadAllNotifications inside a transaction, else`
`2109`	`2110`	`* bad things happen if it gets an error.`

Comments

(0)