NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commita914377

committed

Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.

We were trying to make that strictly an internal implementation detail,but it turns out that it's exposed anyway when dumping a view definedlikeCREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1;This comes out asCREATE VIEW ... ORDER BY "*VALUES*".column1;which fails to parse when reloading the dump.Hacking ruleutils.c to suppress the column qualification looks like it'dbe a risky business, so instead promote the RTE alias to full-fledgedusability.Per bug #6049 from Dylan Adams. Back-patch to all supported branches.

1 parent0484175 commita914377Copy full SHA for a914377

File tree

1 file changed

-1

lines changed

src/backend/parser
- analyze.c

1 file changed

-1

lines changed

`‎src/backend/parser/analyze.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -999,7 +999,7 @@ transformSelectStmt(ParseState pstate, SelectStmt stmt)`
`999`	`999`	`* transforms a VALUES clause that's being used as a standalone SELECT`
`1000`	`1000`	`*`
`1001`	`1001`	`* We build a Query containing a VALUES RTE, rather as if one had written`
`1002`		`- SELECT FROM (VALUES ...)`
	`1002`	`+ SELECT FROM (VALUES ...) AS "VALUES"`
`1003`	`1003`	`*/`
`1004`	`1004`	`staticQuery*`
`1005`	`1005`	`transformValuesClause(ParseStatepstate,SelectStmtstmt)`
`@@ -1162,6 +1162,7 @@ transformValuesClause(ParseState pstate, SelectStmt stmt)`
`1162`	`1162`	`rtr->rtindex=list_length(pstate->p_rtable);`
`1163`	`1163`	`Assert(rte==rt_fetch(rtr->rtindex,pstate->p_rtable));`
`1164`	`1164`	`pstate->p_joinlist=lappend(pstate->p_joinlist,rtr);`
	`1165`	`+pstate->p_relnamespace=lappend(pstate->p_relnamespace,rte);`
`1165`	`1166`	`pstate->p_varnamespace=lappend(pstate->p_varnamespace,rte);`
`1166`	`1167`
`1167`	`1168`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita914377

File tree

1 file changed

1 file changed

`‎src/backend/parser/analyze.c‎`

0 commit comments