NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commita90e9d6

committed

Inserting 5 characters into char(10) does not produce 5 padding spaces

if they are two-byte multibyte characters. Same thing can be happenif octet_length(multibyte_chars) == n where n is char(n).Long standing bug since 7.3 days. Per report and fix from Yoshiyuki Asaba.

1 parent11a0c37 commita90e9d6Copy full SHA for a90e9d6

File tree

1 file changed

-3

lines changed

src/backend/parser
- parse_expr.c

1 file changed

-3

lines changed

`‎src/backend/parser/parse_expr.c‎`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.181 2005/04/06 16:34:06 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.182 2005/05/24 15:45:34 ishii Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -18,6 +18,7 @@`
`18`	`18`	`#include"catalog/pg_operator.h"`
`19`	`19`	`#include"catalog/pg_proc.h"`
`20`	`20`	`#include"commands/dbcommands.h"`
	`21`	`+#include"mb/pg_wchar.h"`
`21`	`22`	`#include"miscadmin.h"`
`22`	`23`	`#include"nodes/makefuncs.h"`
`23`	`24`	`#include"nodes/params.h"`
`@@ -34,7 +35,6 @@`
`34`	`35`	`#include"utils/lsyscache.h"`
`35`	`36`	`#include"utils/syscache.h"`
`36`	`37`
`37`		`-`
`38`	`38`	`boolTransform_null_equals= false;`
`39`	`39`
`40`	`40`	`staticNodetransformParamRef(ParseStatepstate,ParamRef*pref);`
`@@ -1553,7 +1553,13 @@ exprTypmod(Node *expr)`
`1553`	`1553`	`{`
`1554`	`1554`	`caseBPCHAROID:`
`1555`	`1555`	`if (!con->constisnull)`
`1556`		`-returnVARSIZE(DatumGetPointer(con->constvalue));`
	`1556`	`+{`
	`1557`	`+int32len=VARSIZE(DatumGetPointer(con->constvalue))-VARHDRSZ;`
	`1558`	`+`
	`1559`	`+if (pg_database_encoding_max_length()>1)`
	`1560`	`+len=pg_mbstrlen_with_len(VARDATA(DatumGetPointer(con->constvalue)),len);`
	`1561`	`+returnlen+VARHDRSZ;`
	`1562`	`+}`
`1557`	`1563`	`break;`
`1558`	`1564`	`default:`
`1559`	`1565`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita90e9d6

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_expr.c‎`

0 commit comments