NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita756f5c

committed

GROUP BY can only infer functional dependency from non-deferrable primary keys.

Peter's original patch had this right, but I dropped the check while revisingthe code to search pg_constraint instead of pg_index. Spotted by Dean Rasheed.

1 parent8d8d5cb commita756f5cCopy full SHA for a756f5c

File tree

1 file changed

-1

lines changed

src/backend/catalog
- pg_constraint.c

1 file changed

-1

lines changed

`‎src/backend/catalog/pg_constraint.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/pg_constraint.c,v 1.55 2010/08/07 02:44:06 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/pg_constraint.c,v 1.56 2010/09/05 15:45:42 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -836,6 +836,9 @@ check_functional_grouping(Oid relid,`
`836`	`836`	`/* Only PK constraints are of interest for now, see comment above */`
`837`	`837`	`if (con->contype!=CONSTRAINT_PRIMARY)`
`838`	`838`	`continue;`
	`839`	`+/* Constraint must be non-deferrable */`
	`840`	`+if (con->condeferrable)`
	`841`	`+continue;`
`839`	`842`
`840`	`843`	`/* Extract the conkey array, ie, attnums of PK's columns */`
`841`	`844`	`adatum=heap_getattr(tuple,Anum_pg_constraint_conkey,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita756f5c

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_constraint.c`

0 commit comments