NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita481ff7

committed

Remove the isLocalBuf argument from ReadBuffer_common.

Since an SMgrRelation now knows whether or not the underlying relation istemporary, there's no point in also passing that information via anadditional argument.

1 parent79dc97a commita481ff7Copy full SHA for a481ff7

File tree

1 file changed

-6

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-6

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.259 2010/08/14 02:22:10 rhaas Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.260 2010/08/20 01:07:50 rhaas Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -82,7 +82,7 @@ static bool IsForInput;`
`82`	`82`	`staticvolatileBufferDesc*PinCountWaitBuf=NULL;`
`83`	`83`
`84`	`84`
`85`		`-staticBufferReadBuffer_common(SMgrRelationreln,boolisLocalBuf,`
	`85`	`+staticBufferReadBuffer_common(SMgrRelationreln,`
`86`	`86`	`ForkNumberforkNum,BlockNumberblockNum,`
`87`	`87`	`ReadBufferModemode,BufferAccessStrategystrategy,`
`88`	`88`	`bool*hit);`
`@@ -241,7 +241,7 @@ ReadBufferExtended(Relation reln, ForkNumber forkNum, BlockNumber blockNum,`
`241`	`241`	`* miss.`
`242`	`242`	`*/`
`243`	`243`	`pgstat_count_buffer_read(reln);`
`244`		`-buf=ReadBuffer_common(reln->rd_smgr,reln->rd_istemp,forkNum,blockNum,`
	`244`	`+buf=ReadBuffer_common(reln->rd_smgr,forkNum,blockNum,`
`245`	`245`	`mode,strategy,&hit);`
`246`	`246`	`if (hit)`
`247`	`247`	`pgstat_count_buffer_hit(reln);`
`@@ -267,8 +267,7 @@ ReadBufferWithoutRelcache(RelFileNode rnode, ForkNumber forkNum,`
`267`	`267`
`268`	`268`	`SMgrRelationsmgr=smgropen(rnode,InvalidBackendId);`
`269`	`269`
`270`		`-returnReadBuffer_common(smgr, false,forkNum,blockNum,mode,strategy,`
`271`		`-&hit);`
	`270`	`+returnReadBuffer_common(smgr,forkNum,blockNum,mode,strategy,&hit);`
`272`	`271`	`}`
`273`	`272`
`274`	`273`
`@@ -278,14 +277,15 @@ ReadBufferWithoutRelcache(RelFileNode rnode, ForkNumber forkNum,`
`278`	`277`	`* *hit is set to true if the request was satisfied from shared buffer cache.`
`279`	`278`	`*/`
`280`	`279`	`staticBuffer`
`281`		`-ReadBuffer_common(SMgrRelationsmgr,boolisLocalBuf,ForkNumberforkNum,`
	`280`	`+ReadBuffer_common(SMgrRelationsmgr,ForkNumberforkNum,`
`282`	`281`	`BlockNumberblockNum,ReadBufferModemode,`
`283`	`282`	`BufferAccessStrategystrategy,bool*hit)`
`284`	`283`	`{`
`285`	`284`	`volatileBufferDesc*bufHdr;`
`286`	`285`	`BlockbufBlock;`
`287`	`286`	`boolfound;`
`288`	`287`	`boolisExtend;`
	`288`	`+boolisLocalBuf=SmgrIsTemp(smgr);`
`289`	`289`
`290`	`290`	`*hit= false;`
`291`	`291`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita481ff7

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments