NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita32c3ec

committed

Promote the assertion that XLogBeginInsert() is not called twice into ERROR.

Seems like cheap insurance for WAL bugs. A spurious call toXLogBeginInsert() in itself would be fairly harmless, but if there is anydata registered and the insertion is not completed/cancelled properly, thereis a risk that the data ends up in a wrong WAL record.Per Jeff Janes's suggestion.

1 parenta45c70a commita32c3ecCopy full SHA for a32c3ec

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xloginsert.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xloginsert.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -122,12 +122,14 @@ XLogBeginInsert(void)`
`122`	`122`	`Assert(max_registered_block_id==0);`
`123`	`123`	`Assert(mainrdata_last== (XLogRecData*)&mainrdata_head);`
`124`	`124`	`Assert(mainrdata_len==0);`
`125`		`-Assert(!begininsert_called);`
`126`	`125`
`127`	`126`	`/* cross-check on whether we should be here or not */`
`128`	`127`	`if (!XLogInsertAllowed())`
`129`	`128`	`elog(ERROR,"cannot make new WAL entries during recovery");`
`130`	`129`
	`130`	`+if (begininsert_called)`
	`131`	`+elog(ERROR,"XLogBeginInsert was already called");`
	`132`	`+`
`131`	`133`	`begininsert_called= true;`
`132`	`134`	`}`
`133`	`135`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita32c3ec

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xloginsert.c`

0 commit comments