NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita323bce

committed

plpgsql EXIT construct forgot to downcase or quote-strip its identifier

argument, leading to label matching failures at run-time. Per report fromPatrick Fiche. Also, fix it so that an unrecognized label argument drawsa more useful error message than 'syntax error'.

1 parent0b11204 commita323bceCopy full SHA for a323bce

File tree

1 file changed

+13

-2

lines changed

src/pl/plpgsql/src
- gram.y

1 file changed

+13

-2

lines changed

`‎src/pl/plpgsql/src/gram.y`

Lines changed: 13 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`* procedural language`
`5`	`5`	`*`
`6`	`6`	`* IDENTIFICATION`
`7`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.62 2004/09/14 23:46:46 neilc Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.63 2004/10/12 15:44:15 tgl Exp $`
`8`	`8`	`*`
`9`	`9`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`10`	`10`	`*`
`@@ -1639,7 +1639,18 @@ opt_label:`
`1639`	`1639`	`opt_exitlabel:`
`1640`	`1640`	`{$$ =NULL; }`
`1641`	`1641`	`\|T_LABEL`
`1642`		`-{$$ = strdup(yytext); }`
	`1642`	`+{`
	`1643`	`+char*name;`
	`1644`	`+`
	`1645`	`+plpgsql_convert_ident(yytext, &name,1);`
	`1646`	`+$$ = strdup(name);`
	`1647`	`+pfree(name);`
	`1648`	`+}`
	`1649`	`+\|T_WORD`
	`1650`	`+{`
	`1651`	`+/* just to give a better error than "syntax error"*/`
	`1652`	`+yyerror("no such label");`
	`1653`	`+}`
`1643`	`1654`	`;`
`1644`	`1655`
`1645`	`1656`	`opt_exitcond:';'`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita323bce

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/gram.y`

0 commit comments