Commita14424a

committed

Fix off-by-one error in the maxlen parameter handling.

1 parent6cf8ce1 commita14424aCopy full SHA for a14424a

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/Attic/sprompt.c,v 1.3 2002/09/11 17:32:37momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/Attic/sprompt.c,v 1.4 2003/03/18 22:09:37petere Exp $`
`7`	`7`	`*/`
`8`	`8`
`9`	`9`	`/*`
`@@ -45,7 +45,7 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`45`	`45`	`t;`
`46`	`46`	`#endif`
`47`	`47`
`48`		`-destination= (char*)malloc(maxlen+2);`
	`48`	`+destination= (char*)malloc(maxlen+1);`
`49`	`49`	`if (!destination)`
`50`	`50`	`returnNULL;`
`51`	`51`
`@@ -83,7 +83,7 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`83`	`83`	`fflush(termout);`
`84`	`84`	`}`
`85`	`85`
`86`		`-if (fgets(destination,maxlen,termin)==NULL)`
	`86`	`+if (fgets(destination,maxlen+1,termin)==NULL)`
`87`	`87`	`destination[0]='\0';`
`88`	`88`
`89`	`89`	`length=strlen(destination);`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/Attic/sprompt.c,v 1.3 2002/09/04 20:31:36 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/Attic/sprompt.c,v 1.4 2003/03/18 22:09:37 petere Exp $`
`7`	`7`	`*/`
`8`	`8`
`9`	`9`
`@@ -44,7 +44,7 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`44`	`44`	`t;`
`45`	`45`	`#endif`
`46`	`46`
`47`		`-destination= (char*)malloc(maxlen+2);`
	`47`	`+destination= (char*)malloc(maxlen+1);`
`48`	`48`	`if (!destination)`
`49`	`49`	`returnNULL;`
`50`	`50`
`@@ -82,7 +82,7 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`82`	`82`	`fflush(termout);`
`83`	`83`	`}`
`84`	`84`
`85`		`-if (fgets(destination,maxlen,termin)==NULL)`
	`85`	`+if (fgets(destination,maxlen+1,termin)==NULL)`
`86`	`86`	`destination[0]='\0';`
`87`	`87`
`88`	`88`	`length=strlen(destination);`

Comments

(0)