NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commita0c2fa9

committed

isdigit() needs an unsigned char argument.

Per the C standard, the routine should be passed an int, with a value that'srepresentable as an unsigned char or EOF. Passing a signed char is wrong,because a negative value is not representable as an unsigned char.Unfortunately no compiler warns about that.

1 parent94ae6ba commita0c2fa9Copy full SHA for a0c2fa9

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/timestamp.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ parse_sane_timezone(struct pg_tm tm, text zone)`
`511`	`511`	`* as invalid, it's enough to disallow having a digit in the first`
`512`	`512`	`* position of our input string.`
`513`	`513`	`*/`
`514`		`-if (isdigit(*tzname))`
	`514`	`+if (isdigit((unsignedchar)*tzname))`
`515`	`515`	`ereport(ERROR,`
`516`	`516`	`(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`517`	`517`	`errmsg("invalid input syntax for numeric time zone: \"%s\"",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita0c2fa9

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c`

0 commit comments