Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita00d468

Browse files
committed
Remove obsolete commentary.
Since we got rid of non-MVCC catalog scans, the fourth reason given forusing a non-transactional update in index_update_stats() is obsolete.The other three are still good, so we're not going to change the code,but fix the comment.
1 parent18f158e commita00d468

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

‎src/backend/catalog/index.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1784,14 +1784,6 @@ index_update_stats(Relation rel,
17841784
* trying to change the pg_class row to the same thing, so it doesn't
17851785
* matter which goes first).
17861786
*
1787-
* 4. Even with just a single CREATE INDEX, there's a risk factor because
1788-
* someone else might be trying to open the rel while we commit, and this
1789-
* creates a race condition as to whether he will see both or neither of
1790-
* the pg_class row versions as valid. Again, a non-transactional update
1791-
* avoids the risk. It is indeterminate which state of the row the other
1792-
* process will see, but it doesn't matter (if he's only taking
1793-
* AccessShareLock, then it's not critical that he see relhasindex true).
1794-
*
17951787
* It is safe to use a non-transactional update even though our
17961788
* transaction could still fail before committing. Setting relhasindex
17971789
* true is safe even if there are no indexes (VACUUM will eventually fix

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp