NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9f4563f

committed

Use IEEE infinity, not 1e10, for null-and-not-null case in gistpenalty().

Use of a randomly chosen large value was never exactly graceful, andnow that there are penalty functions that are intentionally using infinity,it doesn't seem like a good idea for null-vs-not-null to be using somethingless.

1 parentc66e4f1 commit9f4563fCopy full SHA for 9f4563f

File tree

1 file changed

-2

lines changed

src/backend/access/gist
- gistutil.c

1 file changed

-2

lines changed

`‎src/backend/access/gist/gistutil.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`#include"access/reloptions.h"`
`20`	`20`	`#include"storage/indexfsm.h"`
`21`	`21`	`#include"storage/lmgr.h"`
	`22`	`+#include"utils/builtins.h"`
`22`	`23`
`23`	`24`	`/*`
`24`	`25`	`* static *S used for temrorary storage (saves stack and palloc() call)`
`@@ -538,8 +539,10 @@ gistpenalty(GISTSTATE *giststate, int attno,`
`538`	`539`	`elseif (isNullOrig&&isNullAdd)`
`539`	`540`	`penalty=0.0;`
`540`	`541`	`else`
`541`		`-penalty=1e10;/* try to prevent mixing null and non-null`
`542`		`- * values */`
	`542`	`+{`
	`543`	`+/* try to prevent mixing null and non-null values */`
	`544`	`+penalty=get_float4_infinity();`
	`545`	`+}`
`543`	`546`
`544`	`547`	`returnpenalty;`
`545`	`548`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9f4563f

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistutil.c`

0 commit comments