NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9f1255a

committed

Don't zero opfuncid when reading nodes.

The comments here stated that this was just in case we ever had anALTER OPERATOR command that could remap an operator to a differentfunction. But those comments have been here for a long time, and nosuch command has come about. In the absence of such a feature,forcing the pg_proc OID to be looked up again each time we reread astored rule or similar is just a waste of cycles. Moreover, parallelquery needs a way to reread the exact same node tree that was writtenout, not one that has been slightly stomped on. So just get rid ofthis for now.Per discussion with Tom Lane.

1 parent18d938d commit9f1255aCopy full SHA for 9f1255a

File tree

1 file changed

-44

lines changed

src/backend/nodes
- readfuncs.c

1 file changed

-44

lines changed

`‎src/backend/nodes/readfuncs.c`

Lines changed: 0 additions & 44 deletions

Original file line number	Diff line number	Diff line change
`@@ -665,17 +665,6 @@ _readOpExpr(void)`
`665`	`665`
`666`	`666`	`READ_OID_FIELD(opno);`
`667`	`667`	`READ_OID_FIELD(opfuncid);`
`668`		`-`
`669`		`-/*`
`670`		`- * The opfuncid is stored in the textual format primarily for debugging`
`671`		`- * and documentation reasons. We want to always read it as zero to force`
`672`		`- * it to be re-looked-up in the pg_operator entry. This ensures that`
`673`		`- * stored rules don't have hidden dependencies on operators' functions.`
`674`		`- * (We don't currently support an ALTER OPERATOR command, but might`
`675`		`- * someday.)`
`676`		`- */`
`677`		`-local_node->opfuncid=InvalidOid;`
`678`		`-`
`679`	`668`	`READ_OID_FIELD(opresulttype);`
`680`	`669`	`READ_BOOL_FIELD(opretset);`
`681`	`670`	`READ_OID_FIELD(opcollid);`
`@@ -696,17 +685,6 @@ _readDistinctExpr(void)`
`696`	`685`
`697`	`686`	`READ_OID_FIELD(opno);`
`698`	`687`	`READ_OID_FIELD(opfuncid);`
`699`		`-`
`700`		`-/*`
`701`		`- * The opfuncid is stored in the textual format primarily for debugging`
`702`		`- * and documentation reasons. We want to always read it as zero to force`
`703`		`- * it to be re-looked-up in the pg_operator entry. This ensures that`
`704`		`- * stored rules don't have hidden dependencies on operators' functions.`
`705`		`- * (We don't currently support an ALTER OPERATOR command, but might`
`706`		`- * someday.)`
`707`		`- */`
`708`		`-local_node->opfuncid=InvalidOid;`
`709`		`-`
`710`	`688`	`READ_OID_FIELD(opresulttype);`
`711`	`689`	`READ_BOOL_FIELD(opretset);`
`712`	`690`	`READ_OID_FIELD(opcollid);`
`@@ -727,17 +705,6 @@ _readNullIfExpr(void)`
`727`	`705`
`728`	`706`	`READ_OID_FIELD(opno);`
`729`	`707`	`READ_OID_FIELD(opfuncid);`
`730`		`-`
`731`		`-/*`
`732`		`- * The opfuncid is stored in the textual format primarily for debugging`
`733`		`- * and documentation reasons. We want to always read it as zero to force`
`734`		`- * it to be re-looked-up in the pg_operator entry. This ensures that`
`735`		`- * stored rules don't have hidden dependencies on operators' functions.`
`736`		`- * (We don't currently support an ALTER OPERATOR command, but might`
`737`		`- * someday.)`
`738`		`- */`
`739`		`-local_node->opfuncid=InvalidOid;`
`740`		`-`
`741`	`708`	`READ_OID_FIELD(opresulttype);`
`742`	`709`	`READ_BOOL_FIELD(opretset);`
`743`	`710`	`READ_OID_FIELD(opcollid);`
`@@ -758,17 +725,6 @@ _readScalarArrayOpExpr(void)`
`758`	`725`
`759`	`726`	`READ_OID_FIELD(opno);`
`760`	`727`	`READ_OID_FIELD(opfuncid);`
`761`		`-`
`762`		`-/*`
`763`		`- * The opfuncid is stored in the textual format primarily for debugging`
`764`		`- * and documentation reasons. We want to always read it as zero to force`
`765`		`- * it to be re-looked-up in the pg_operator entry. This ensures that`
`766`		`- * stored rules don't have hidden dependencies on operators' functions.`
`767`		`- * (We don't currently support an ALTER OPERATOR command, but might`
`768`		`- * someday.)`
`769`		`- */`
`770`		`-local_node->opfuncid=InvalidOid;`
`771`		`-`
`772`	`728`	`READ_BOOL_FIELD(useOr);`
`773`	`729`	`READ_OID_FIELD(inputcollid);`
`774`	`730`	`READ_NODE_FIELD(args);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9f1255a

File tree

1 file changed

1 file changed

`‎src/backend/nodes/readfuncs.c`

0 commit comments