NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit9e3755e

committed

Remove useless duplicate inclusions of system header files.

c.h #includes a number of core libc header files, such as <stdio.h>.There's no point in re-including these after having read postgres.h,postgres_fe.h, or c.h; so remove code that did so.While at it, also fix some places that were ignoring our standard patternof "include postgres[_fe].h, then system header files, then other Postgresheader files". While there's not any great magic in doing it that wayrather than system headers last, it's silly to have just a few filesdeviating from the general pattern. (But I didn't attempt to enforce thisglobally, only in files I was touching anyway.)I'd be the first to say that this is mostly compulsive neatnik-ism,but over time it might save enough compile cycles to be useful.

1 parent5639ced commit9e3755eCopy full SHA for 9e3755e

File tree

77 files changed

+41

-155

lines changed

contrib
- fuzzystrmatch
  - dmetaphone.c
- ltree
  - crc32.c
- pgcrypto
  - px.h
src
- backend
  - access/transam
  - commands
    - dbcommands.c
    - tablespace.c
  - libpq
    - ifaddr.c
  - port
    - atomics.c
    - dynloader
    - win32
      - crashdump.c
  - postmaster
    - autovacuum.c
  - replication
    - basebackup.c
    - logical
      - snapbuild.c
    - walreceiverfuncs.c
  - storage/ipc
  - utils
    - adt
    - init
      - miscinit.c
- bin
  - initdb
    - initdb.c
  - pg_basebackup
  - pg_ctl
    - pg_ctl.c
  - pg_dump
  - pg_resetwal
    - pg_resetwal.c
  - pg_rewind
  - pg_upgrade
  - pgevent
    - pgevent.c
  - psql
- common
- fe_utils
  - print.c
- include
  - libpq
    - libpq.h
  - port/atomics
    - generic-msvc.h
  - utils
    - pg_locale.h
- interfaces
  - ecpg
    - ecpglib
    - preproc
      - ecpg.c
      - pgc.l
  - libpq
- pl/plperl
  - plperl.c
- port
- test/isolation
  - isolationtester.c
- timezone
  - strftime.c
  - zic.c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+41

-155

lines changed

`‎contrib/fuzzystrmatch/dmetaphone.c‎`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -93,9 +93,6 @@ The remaining code is authored by Andrew Dunstan <amdunstan@ncshp.org> and`
`93`	`93`	`***********************************************************************/`
`94`	`94`
`95`	`95`
`96`		`-`
`97`		`-`
`98`		`-`
`99`	`96`	`/* include these first, according to the docs */`
`100`	`97`	`#ifndefDMETAPHONE_MAIN`
`101`	`98`
`@@ -105,14 +102,19 @@ The remaining code is authored by Andrew Dunstan <amdunstan@ncshp.org> and`
`105`	`102`
`106`	`103`	`/* turn off assertions for embedded function */`
`107`	`104`	`#defineNDEBUG`
`108`		`-#endif`
`109`	`105`
	`106`	`+#else/* DMETAPHONE_MAIN */`
	`107`	`+`
	`108`	`+/* we need these if we didn't get them from postgres.h */`
`110`	`109`	`#include<stdio.h>`
`111`		`-#include<ctype.h>`
`112`	`110`	`#include<stdlib.h>`
`113`	`111`	`#include<string.h>`
`114`	`112`	`#include<stdarg.h>`
	`113`	`+`
	`114`	`+#endif/* DMETAPHONE_MAIN */`
	`115`	`+`
`115`	`116`	`#include<assert.h>`
	`117`	`+#include<ctype.h>`
`116`	`118`
`117`	`119`	`/* prototype for the main function we got from the perl module */`
`118`	`120`	`staticvoidDoubleMetaphone(char,char*);`