Commit9dd6c46

committed

Let's try forcing errno to zero before issuing fsync. The current buildfarm

results claiming EBADF seem improbable enough that I'm not convinced fsyncis really returning that --- could it be failing to set errno at all?

1 parente9a3833 commit9dd6c46Copy full SHA for 9dd6c46

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*as a service.`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/port/copydir.c,v 1.30 2010/02/2202:50:10 tgl Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/port/copydir.c,v 1.31 2010/02/2215:29:46 tgl Exp $`
`15`	`15`	`*`
`16`	`16`	`*-------------------------------------------------------------------------`
`17`	`17`	`*/`
`@@ -229,9 +229,12 @@ fsync_fname(char *fname)`
`229`	`229`	`(errcode_for_file_access(),`
`230`	`230`	`errmsg("could not open file \"%s\": %m",fname)));`
`231`	`231`
	`232`	`+errno=0;`
	`233`	`+`
`232`	`234`	`if (pg_fsync(fd)!=0)`
`233`	`235`	`ereport(ERROR,`
`234`	`236`	`(errcode_for_file_access(),`
`235`	`237`	`errmsg("could not fsync file \"%s\": %m",fname)));`
	`238`	`+`
`236`	`239`	`close(fd);`
`237`	`240`	`}`

Comments

(0)