NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9d1ac2f

committed

Tweak create_index_paths()'s test for whether to consider a bitmap scan.

Per my note of a couple days ago, create_index_paths would refuse toconsider any path at all for GIN indexes if the selectivity estimate cameout as 1.0; not even if you tried to force it with enable_seqscan. Whilethis isn't really a bad outcome in practice, it could be annoying fortesting purposes. Adjust the test for "is this path only useful forsorting" so that it doesn't fire on paths with nil pathkeys, which willinclude all GIN paths.

1 parent1c400d3 commit9d1ac2fCopy full SHA for 9d1ac2f

File tree

1 file changed

-2

lines changed

src/backend/optimizer/path
- indxpath.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/path/indxpath.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -196,8 +196,8 @@ create_index_paths(PlannerInfo root, RelOptInfo rel)`
`196`	`196`	`add_path(rel, (Path*)ipath);`
`197`	`197`
`198`	`198`	`if (ipath->indexinfo->amhasgetbitmap&&`
`199`		`-ipath->indexselectivity<1.0&&`
`200`		`-!ScanDirectionIsBackward(ipath->indexscandir))`
	`199`	`+(ipath->path.pathkeys==NIL\|\|`
	`200`	`+ipath->indexselectivity<1.0))`
`201`	`201`	`bitindexpaths=lappend(bitindexpaths,ipath);`
`202`	`202`	`}`
`203`	`203`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9d1ac2f

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/indxpath.c`

0 commit comments