NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9d140f7

committed

Avoid out-of-bounds read in errfinish if error_stack_depth < 0.

If errordata_stack_depth < 0, we won't find that out and correct theproblem until CHECK_STACK_DEPTH() is invoked. In the meantime,elevel will be set based on an invalid read. This is probablyharmless in practice, but it seems cleaner this way.Xi Wang

1 parent3e3520c commit9d140f7Copy full SHA for 9d140f7

File tree

1 file changed

-1

lines changed

src/backend/utils/error
- elog.c

1 file changed

-1

lines changed

`‎src/backend/utils/error/elog.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -397,12 +397,13 @@ void`
`397`	`397`	`errfinish(intdummy,...)`
`398`	`398`	`{`
`399`	`399`	`ErrorData*edata=&errordata[errordata_stack_depth];`
`400`		`-intelevel=edata->elevel;`
	`400`	`+intelevel;`
`401`	`401`	`MemoryContextoldcontext;`
`402`	`402`	`ErrorContextCallback*econtext;`
`403`	`403`
`404`	`404`	`recursion_depth++;`
`405`	`405`	`CHECK_STACK_DEPTH();`
	`406`	`+elevel=edata->elevel;`
`406`	`407`
`407`	`408`	`/*`
`408`	`409`	`* Do processing in ErrorContext, which we hope has enough reserved space`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9d140f7

File tree

1 file changed

1 file changed

`‎src/backend/utils/error/elog.c`

0 commit comments