NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9c0e2b9

committed

Fix walsender handling of postmaster shutdown, to not go into endless loop.

This bug was introduced by my patch to use the regular die/quickdie signalhandlers in walsender processes. I tried to make walsender exit at nextCHECK_FOR_INTERRUPTS() by setting ProcDiePending, but that's not enough, youneed to set InterruptPending too. On second thoght, it was not a very goodway to make walsender exit anyway, so use proc_exit(0) instead.Also, send a CommandComplete message before exiting; that's what we didbefore, and you get a nicer error message in the standby that way.Reported by Thom Brown.

1 parent95d035e commit9c0e2b9Copy full SHA for 9c0e2b9

File tree

1 file changed

-2

lines changed

src/backend/replication
- walsender.c

1 file changed

-2

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -711,8 +711,11 @@ WalSndLoop(void)`
`711`	`711`	`XLogSend(output_message,&caughtup);`
`712`	`712`	`if (caughtup&& !pq_is_send_pending())`
`713`	`713`	`{`
`714`		`-ProcDiePending= true;`
`715`		`-continue;/* don't want to wait more */`
	`714`	`+/* Inform the standby that XLOG streaming is done */`
	`715`	`+pq_puttextmessage('C',"COPY 0");`
	`716`	`+pq_flush();`
	`717`	`+`
	`718`	`+proc_exit(0);`
`716`	`719`	`}`
`717`	`720`	`}`
`718`	`721`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9c0e2b9

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c`

0 commit comments