NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9ac4299

committed

HeapTupleHeaderAdjustCmax made the incorrect assumption that the raw

command id is the cmin, when it can in fact be a combo cid. That made rowsincorrectly invisible to a transaction where a tuple was deleted by multipleaborted subtransactions.Report and patch Karl Schnaitter. Back-patch to 8.3, where combo cids wasintroduced.

1 parent86ec73b commit9ac4299Copy full SHA for 9ac4299

File tree

1 file changed

-2

lines changed

src/backend/utils/time
- combocid.c

1 file changed

-2

lines changed

`‎src/backend/utils/time/combocid.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`* Portions Copyright (c) 1994, Regents of the University of California`
`35`	`35`	`*`
`36`	`36`	`* IDENTIFICATION`
`37`		`- * $PostgreSQL: pgsql/src/backend/utils/time/combocid.c,v 1.4 2008/01/0119:45:55 momjian Exp $`
	`37`	`+ * $PostgreSQL: pgsql/src/backend/utils/time/combocid.c,v 1.5 2008/09/0118:52:45 heikki Exp $`
`38`	`38`	`*`
`39`	`39`	`*-------------------------------------------------------------------------`
`40`	`40`	`*/`
`@@ -155,7 +155,7 @@ HeapTupleHeaderAdjustCmax(HeapTupleHeader tup,`
`155`	`155`	`if (!(tup->t_infomask&HEAP_XMIN_COMMITTED)&&`
`156`	`156`	`TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetXmin(tup)))`
`157`	`157`	`{`
`158`		`-CommandIdcmin=HeapTupleHeaderGetRawCommandId(tup);`
	`158`	`+CommandIdcmin=HeapTupleHeaderGetCmin(tup);`
`159`	`159`
`160`	`160`	`cmax=GetComboCommandId(cmin,cmax);`
`161`	`161`	`*iscombo= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9ac4299

File tree

1 file changed

1 file changed

`‎src/backend/utils/time/combocid.c`

0 commit comments