NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit994f112

committed

Adjust datatype of ReplicationState.acquired_by.

It was declared as "pid_t", which would be fine except that none ofthe places that printed it in error messages took any thought for thepossibility that it's not equivalent to "int". This leads to warningson some buildfarm members, and could possibly lead to actually wrongerror messages on those platforms. There doesn't seem to be any verygood reason not to just make it "int"; it's only ever assigned fromMyProcPid, which is int. If we want to cope with PIDs that are widerthan int, this is not the place to start.Also, fix the comment, which seems to perhaps be a leftover from a timewhen the field was only a bool?Per buildfarm. Back-patch to 9.5 which has same issue.

1 parentfda21aa commit994f112Copy full SHA for 994f112

File tree

1 file changed

-2

lines changed

src/backend/replication/logical
- origin.c

1 file changed

-2

lines changed

`‎src/backend/replication/logical/origin.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -120,9 +120,9 @@ typedef struct ReplicationState`
`120`	`120`	`XLogRecPtrlocal_lsn;`
`121`	`121`
`122`	`122`	`/*`
`123`		`- *Slot is setup in backend?`
	`123`	`+ *PID of backend that's acquired slot, or 0 if none.`
`124`	`124`	`*/`
`125`		`-pid_tacquired_by;`
	`125`	`+intacquired_by;`
`126`	`126`
`127`	`127`	`/*`
`128`	`128`	`* Lock protecting remote_lsn and local_lsn.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit994f112

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/origin.c`

0 commit comments