NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit9711fa0

committed

Fix undersized result buffer in pset_quoted_string().

The malloc request was 1 byte too small for the worst-case output.This seems relatively unlikely to cause any problems in practice,as the worst case only occurs if the input string contains nocharacters other than single-quote or newline, and even thenmalloc alignment padding would probably save the day. But it'sdefinitely a bug.David Rowley

1 parenta4523c5 commit9711fa0Copy full SHA for 9711fa0

File tree

1 file changed

-1

lines changed

src/bin/psql
- command.c

1 file changed

-1

lines changed

`‎src/bin/psql/command.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2711,7 +2711,7 @@ pset_bool_string(bool val)`
`2711`	`2711`	`staticchar*`
`2712`	`2712`	`pset_quoted_string(constchar*str)`
`2713`	`2713`	`{`
`2714`		`-charret=pg_malloc(strlen(str)2+2);`
	`2714`	`+charret=pg_malloc(strlen(str)2+3);`
`2715`	`2715`	`char*r=ret;`
`2716`	`2716`
`2717`	`2717`	`*r++='\'';`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9711fa0

File tree

1 file changed

1 file changed

`‎src/bin/psql/command.c`

0 commit comments