NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit96f8373

committed

Fix bug in aggregate (de)serialization commit.

resulttypeLen and resulttypeByVal must be set correctly when serializingaggregates, not just when finalizing them. This was in David's finalpatch but I downloaded the wrong version by mistake and failed to spotthe error.David Rowley

1 parent5fe5a2c commit96f8373Copy full SHA for 96f8373

File tree

1 file changed

-5

lines changed

src/backend/executor
- nodeAgg.c

1 file changed

-5

lines changed

`‎src/backend/executor/nodeAgg.c‎`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2862,11 +2862,10 @@ ExecInitAgg(Agg node, EState estate, int eflags)`
`2862`	`2862`	`fmgr_info_set_expr((Node*)finalfnexpr,&peragg->finalfn);`
`2863`	`2863`	`}`
`2864`	`2864`
`2865`		`-/* when finalizing we get info about the final result's datatype */`
`2866`		`-if (aggstate->finalizeAggs)`
`2867`		`-get_typlenbyval(aggref->aggtype,`
`2868`		`-&peragg->resulttypeLen,`
`2869`		`-&peragg->resulttypeByVal);`
	`2865`	`+/* get info about the output value's datatype */`
	`2866`	`+get_typlenbyval(aggref->aggoutputtype,`
	`2867`	`+&peragg->resulttypeLen,`
	`2868`	`+&peragg->resulttypeByVal);`
`2870`	`2869`
`2871`	`2870`	`/*`
`2872`	`2871`	`* initval is potentially null, so don't try to access it as a struct`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit96f8373

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeAgg.c‎`

0 commit comments