NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit942702a

committed

When you do "ARRAY[...]::domain", where domain is a domain over an array type,

we need to check domain constraints. We used to do it correctly, but 8.4introduced a separate code path for the "ARRAY[]::arraytype" case to inferthe type of an empty ARRAY construct from the cast target, and forgot to takedomains into account.Per report from Florian G. Pflug.

1 parent5e75f67 commit942702aCopy full SHA for 942702a

File tree

1 file changed

+15

-1

lines changed

src/backend/parser
- parse_expr.c

1 file changed

+15

-1

lines changed

`‎src/backend/parser/parse_expr.c`

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.248 2009/11/09 02:36:56 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.249 2009/11/13 16:09:10 heikki Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -169,6 +169,20 @@ transformExpr(ParseState pstate, Node expr)`
`169`	`169`	`targetType,`
`170`	`170`	`elementType,`
`171`	`171`	`targetTypmod);`
	`172`	`+`
	`173`	`+/*`
	`174`	`+ * If the target array type is a domain, we still need`
	`175`	`+ * to check the domain constraint. (coerce_to_domain`
	`176`	`+ * is a no-op if targetType is not a domain)`
	`177`	`+ */`
	`178`	`+result=coerce_to_domain(result,`
	`179`	`+InvalidOid,`
	`180`	`+-1,`
	`181`	`+targetType,`
	`182`	`+COERCE_IMPLICIT_CAST,`
	`183`	`+tc->location,`
	`184`	`+ false,`
	`185`	`+ true);`
`172`	`186`	`break;`
`173`	`187`	`}`
`174`	`188`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit942702a

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_expr.c`

0 commit comments