Commit92eacaf

committed

Change exp() behavior to generate error on underflow rather

than silently returning zero on some machines. Correct float8 regress testto agree. Also fix pow() overflow/underflow check to work correctly onHPUX.

1 parent67531c4 commit92eacafCopy full SHA for 92eacaf

File tree

-12

lines changed

-12

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/float.c,v 1.34 1998/11/17 14:36:44 thomas Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/float.c,v 1.35 1998/11/29 01:57:59 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1131,7 +1131,7 @@ dpow(float64 arg1, float64 arg2)`
`1131`	`1131`	`#endif`
`1132`	`1132`	`*result= (float64data)pow(tmp1,tmp2);`
`1133`	`1133`	`#ifndeffinite`
`1134`		`-if (errno==ERANGE)`
	`1134`	`+if (errno!=0)/* on some machines both EDOM & ERANGE can occur */`
`1135`	`1135`	`#else`
`1136`	`1136`	`if (!finite(*result))`
`1137`	`1137`	`#endif`
`@@ -1164,7 +1164,8 @@ dexp(float64 arg1)`
`1164`	`1164`	`#ifndeffinite`
`1165`	`1165`	`if (errno==ERANGE)`
`1166`	`1166`	`#else`
`1167`		`-if (!finite(*result))`
	`1167`	`+/* infinity implies overflow, zero implies underflow */`
	`1168`	`+if (!finite(result)\|\|result==0.0)`
`1168`	`1169`	`#endif`
`1169`	`1170`	`elog(ERROR,"exp() result is out of range");`
`1170`	`1171`

Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -195,15 +195,7 @@ ERROR: can't take log of zero`
`195`	`195`	`QUERY: SELECT '' AS bad, (; (f.f1)) from FLOAT8_TBL f where f.f1 < '0.0' ;`
`196`	`196`	`ERROR: can't take log of a negative number`
`197`	`197`	`QUERY: SELECT '' AS bad, : (f.f1) from FLOAT8_TBL f;`
`198`		`-bad\| ?column?`
`199`		`----+--------------------`
`200`		`- \| 1`
`201`		`- \|7.39912306090513e-16`
`202`		`- \| 0`
`203`		`- \| 0`
`204`		`- \| 1`
`205`		`-(5 rows)`
`206`		`-`
	`198`	`+ERROR: exp() result is out of range`
`207`	`199`	`QUERY: SELECT '' AS bad, f.f1 / '0.0' from FLOAT8_TBL f;`
`208`	`200`	`ERROR: float8div: divide by zero error`
`209`	`201`	`QUERY: SELECT '' AS five, FLOAT8_TBL.*;`

Comments

(0)