Commit9043ef3

committed

Don't warn about creating temporary or unlogged hash indexes.

Warning people that no WAL-logging will be done doesn't make sensein this case.Michael Paquier

1 parent91118f1 commit9043ef3Copy full SHA for 9043ef3

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,8 @@ DefineIndex(Oid relationId,`
`490`	`490`	`accessMethodId=HeapTupleGetOid(tuple);`
`491`	`491`	`accessMethodForm= (Form_pg_am)GETSTRUCT(tuple);`
`492`	`492`
`493`		`-if (strcmp(accessMethodName,"hash")==0)`
	`493`	`+if (strcmp(accessMethodName,"hash")==0&&`
	`494`	`+RelationNeedsWAL(rel))`
`494`	`495`	`ereport(WARNING,`
`495`	`496`	`(errmsg("hash indexes are not WAL-logged and their use is discouraged")));`
`496`	`497`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2342,6 +2342,9 @@ CREATE INDEX hash_txt_index ON hash_txt_heap USING hash (random text_ops);`
`2342`	`2342`	`WARNING: hash indexes are not WAL-logged and their use is discouraged`
`2343`	`2343`	`CREATE INDEX hash_f8_index ON hash_f8_heap USING hash (random float8_ops);`
`2344`	`2344`	`WARNING: hash indexes are not WAL-logged and their use is discouraged`
	`2345`	`+CREATE UNLOGGED TABLE unlogged_hash_table (id int4);`
	`2346`	`+CREATE INDEX unlogged_hash_index ON unlogged_hash_table USING hash (id int4_ops);`
	`2347`	`+DROP TABLE unlogged_hash_table;`
`2345`	`2348`	`-- CREATE INDEX hash_ovfl_index ON hash_ovfl_heap USING hash (x int4_ops);`
`2346`	`2349`	`--`
`2347`	`2350`	`-- Test functional index`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -684,6 +684,10 @@ CREATE INDEX hash_txt_index ON hash_txt_heap USING hash (random text_ops);`
`684`	`684`
`685`	`685`	`CREATEINDEXhash_f8_indexON hash_f8_heap USING hash (random float8_ops);`
`686`	`686`
	`687`	`+CREATE UNLOGGED TABLE unlogged_hash_table (id int4);`
	`688`	`+CREATEINDEXunlogged_hash_indexON unlogged_hash_table USING hash (id int4_ops);`
	`689`	`+DROPTABLE unlogged_hash_table;`
	`690`	`+`
`687`	`691`	`-- CREATE INDEX hash_ovfl_index ON hash_ovfl_heap USING hash (x int4_ops);`
`688`	`692`
`689`	`693`

Comments

(0)