NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit902d1cb

committed

Remove all uses of the deprecated functions heap_formtuple, heap_modifytuple,

and heap_deformtuple in favor of the newer functions heap_form_tuple et al(which do the same things but use bool control flags instead of arbitrarychar values). Eliminate the former duplicate coding of these functions,reducing the deprecated functions to mere wrappers around the newer ones.We can't get rid of them entirely because add-on modules probably stillcontain many instances of the old coding style.Kris Jurka

1 parent492059d commit902d1cbCopy full SHA for 902d1cb

File tree

46 files changed

+631

-1014

lines changed

contrib/hstore
- hstore_op.c
src
- backend
  - access
    - common
      - heaptuple.c
    - heap
      - tuptoaster.c
  - bootstrap
    - bootstrap.c
  - catalog
  - commands
  - executor
    - execTuples.c
    - spi.c
  - optimizer/prep
    - preptlist.c
  - rewrite
    - rewriteDefine.c
  - storage/large_object
    - inv_api.c
  - utils
    - adt
      - lockfuncs.c
      - rowtypes.c
    - cache
      - catcache.c
- include
  - access
    - htup.h
  - funcapi.h
- pl
  - plpgsql/src
    - pl_exec.c
  - plpython
    - plpython.c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+631

-1014

lines changed

`‎contrib/hstore/hstore_op.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ each(PG_FUNCTION_ARGS)`
`610`	`610`	`HEntry*ptr=&(ARRPTR(st->hs)[st->i]);`
`611`	`611`	`Datumres,`
`612`	`612`	`dvalues[2];`
`613`		`-charnulls[]= {' ',' '};`
	`613`	`+boolnulls[2]= {false, false};`
`614`	`614`	`text*item;`
`615`	`615`	`HeapTupletuple;`
`616`	`616`
`@@ -620,7 +620,7 @@ each(PG_FUNCTION_ARGS)`
`620`	`620`	`if (ptr->valisnull)`
`621`	`621`	`{`
`622`	`622`	`dvalues[1]= (Datum)0;`
`623`		`-nulls[1]='n';`
	`623`	`+nulls[1]=true;`
`624`	`624`	`}`
`625`	`625`	`else`
`626`	`626`	`{`
`@@ -630,11 +630,11 @@ each(PG_FUNCTION_ARGS)`
`630`	`630`	`}`
`631`	`631`	`st->i++;`
`632`	`632`
`633`		`-tuple=heap_formtuple(funcctx->attinmeta->tupdesc,dvalues,nulls);`
	`633`	`+tuple=heap_form_tuple(funcctx->attinmeta->tupdesc,dvalues,nulls);`
`634`	`634`	`res=HeapTupleGetDatum(tuple);`
`635`	`635`
`636`	`636`	`pfree(DatumGetPointer(dvalues[0]));`
`637`		`-if (nulls[1]!='n')`
	`637`	`+if (!nulls[1])`
`638`	`638`	`pfree(DatumGetPointer(dvalues[1]));`
`639`	`639`
`640`	`640`	`SRF_RETURN_NEXT(funcctx,PointerGetDatum(res));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit902d1cb

File tree

46 files changed

Some content is hidden

46 files changed

`‎contrib/hstore/hstore_op.c`

0 commit comments