NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8f4a369

committed

Fix crash bug in RestoreSnapshot.

If serialized_snapshot->subxcnt > 0 and serialized_snapshot->xcnt == 0,the old coding would do the wrong thing and crash. This can happenon standby servers.Report by Andreas Seltenreich. Patch by Thomas Munro, reviewed byAmit Kapila and tested by Andreas Seltenreich.

1 parent8caf9fe commit8f4a369Copy full SHA for 8f4a369

File tree

1 file changed

-1

lines changed

src/backend/utils/time
- snapmgr.c

1 file changed

-1

lines changed

`‎src/backend/utils/time/snapmgr.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1573,7 +1573,8 @@ RestoreSnapshot(char *start_address)`
`1573`	`1573`	`/* Copy SubXIDs, if present. */`
`1574`	`1574`	`if (serialized_snapshot->subxcnt>0)`
`1575`	`1575`	`{`
`1576`		`-snapshot->subxip=snapshot->xip+serialized_snapshot->xcnt;`
	`1576`	`+snapshot->subxip= ((TransactionId*) (snapshot+1))+`
	`1577`	`+serialized_snapshot->xcnt;`
`1577`	`1578`	`memcpy(snapshot->subxip,serialized_xids+serialized_snapshot->xcnt,`
`1578`	`1579`	`serialized_snapshot->subxcnt*sizeof(TransactionId));`
`1579`	`1580`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8f4a369

File tree

1 file changed

1 file changed

`‎src/backend/utils/time/snapmgr.c`

0 commit comments