NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8caf9fe

committed

Fix typo in ReorderBufferIterTXNInit().

This looks like it would cause changes from subtransactions to be missedby the iterator being constructed, if those changes had been spilled todisk previously. This implies that large subtransactions might be lost(in whole or in part) by logical replication. Found and fixed byPetru-Florin Mihancea, per bug #14208.Report: <20160622144830.5791.22512@wrigleys.postgresql.org>

1 parent1651b9a commit8caf9feCopy full SHA for 8caf9fe

File tree

1 file changed

-1

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-1

lines changed

`‎src/backend/replication/logical/reorderbuffer.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ ReorderBufferIterTXNInit(ReorderBuffer rb, ReorderBufferTXN txn)`
`897`	`897`	`{`
`898`	`898`	`ReorderBufferChange*cur_change;`
`899`	`899`
`900`		`-if (txn->nentries!=txn->nentries_mem)`
	`900`	`+if (cur_txn->nentries!=cur_txn->nentries_mem)`
`901`	`901`	`ReorderBufferRestoreChanges(rb,cur_txn,`
`902`	`902`	`&state->entries[off].fd,`
`903`	`903`	`&state->entries[off].segno);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8caf9fe

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c`

0 commit comments