Commit8af3596

committed

Async dblink functions require a named connection, and therefore should

use DBLINK_GET_NAMED_CONN rather than DBLINK_GET_CONN.Problem found by Peter Eisentraut and patch by Fujii Masao.

1 parenteb03cff commit8af3596Copy full SHA for 8af3596

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -613,16 +613,13 @@ Datum`
`613`	`613`	`dblink_send_query(PG_FUNCTION_ARGS)`
`614`	`614`	`{`
`615`	`615`	`PGconn*conn=NULL;`
`616`		`-char*connstr=NULL;`
`617`	`616`	`char*sql=NULL;`
`618`	`617`	`remoteConn*rconn=NULL;`
`619`		`-char*msg;`
`620`		`-boolfreeconn= false;`
`621`	`618`	`intretval;`
`622`	`619`
`623`	`620`	`if (PG_NARGS()==2)`
`624`	`621`	`{`
`625`		`-DBLINK_GET_CONN;`
	`622`	`+DBLINK_GET_NAMED_CONN;`
`626`	`623`	`sql=text_to_cstring(PG_GETARG_TEXT_PP(1));`
`627`	`624`	`}`
`628`	`625`	`else`
`@@ -711,13 +708,13 @@ dblink_record_internal(FunctionCallInfo fcinfo, bool is_async)`
`711`	`708`	`if (PG_NARGS()==2)`
`712`	`709`	`{`
`713`	`710`	`/* text,bool */`
`714`		`-DBLINK_GET_CONN;`
	`711`	`+DBLINK_GET_NAMED_CONN;`
`715`	`712`	`fail=PG_GETARG_BOOL(1);`
`716`	`713`	`}`
`717`	`714`	`elseif (PG_NARGS()==1)`
`718`	`715`	`{`
`719`	`716`	`/* text */`
`720`		`-DBLINK_GET_CONN;`
	`717`	`+DBLINK_GET_NAMED_CONN;`
`721`	`718`	`}`
`722`	`719`	`else`
`723`	`720`	`/* shouldn't happen */`

Comments

(0)