Commit8a8c6b5

committed

Fix crash when pg_get_viewdef_name_ext() is passed a non-view relation.

Oversight in commit976b24f.Andreas SeltenreichReport: <87y448l3ag.fsf@credativ.de>

1 parent9ee1cf0 commit8a8c6b5Copy full SHA for 8a8c6b5

File tree

-1

lines changed

-1

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -671,14 +671,20 @@ pg_get_viewdef_name_ext(PG_FUNCTION_ARGS)`
`671`	`671`	`intprettyFlags;`
`672`	`672`	`RangeVar*viewrel;`
`673`	`673`	`Oidviewoid;`
	`674`	`+char*res;`
`674`	`675`
`675`	`676`	`prettyFlags=pretty ?PRETTYFLAG_PAREN \|PRETTYFLAG_INDENT :PRETTYFLAG_INDENT;`
`676`	`677`
`677`	`678`	`/* Look up view name. Can't lock it - we might not have privileges. */`
`678`	`679`	`viewrel=makeRangeVarFromNameList(textToQualifiedNameList(viewname));`
`679`	`680`	`viewoid=RangeVarGetRelid(viewrel,NoLock, false);`
`680`	`681`
`681`		`-PG_RETURN_TEXT_P(string_to_text(pg_get_viewdef_worker(viewoid,prettyFlags,WRAP_COLUMN_DEFAULT)));`
	`682`	`+res=pg_get_viewdef_worker(viewoid,prettyFlags,WRAP_COLUMN_DEFAULT);`
	`683`	`+`
	`684`	`+if (res==NULL)`
	`685`	`+PG_RETURN_NULL();`
	`686`	`+`
	`687`	`+PG_RETURN_TEXT_P(string_to_text(res));`
`682`	`688`	`}`
`683`	`689`
`684`	`690`	`/*`

Comments

(0)