NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8a8c581

committed

Remove unnecessary NULL test.

Spotted by Coverity and reported by Michael Paquier. Per discussion,we don't necessarily care about making Coverity happy in all suchinstances, but we can go ahead and change them where it otherwiseseems to improve the code.

1 parent31c018e commit8a8c581Copy full SHA for 8a8c581

File tree

1 file changed

-2

lines changed

src/bin/pg_upgrade
- controldata.c

1 file changed

-2

lines changed

`‎src/bin/pg_upgrade/controldata.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)`
`402`	`402`	`}`
`403`	`403`	`}`
`404`	`404`
`405`		`-if (output)`
`406`		`-pclose(output);`
	`405`	`+pclose(output);`
`407`	`406`
`408`	`407`	`/*`
`409`	`408`	`* Restore environment variables`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8a8c581

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/controldata.c`

0 commit comments