Commit898a792

committed

Fix connection leak in DROP SUBSCRIPTION command.

Previously the command forgot to close the connection to the publisherwhen it failed to drop the replication slot.

1 parent1d04a59 commit898a792Copy full SHA for 898a792

File tree

-0

lines changed

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -546,10 +546,14 @@ DropSubscription(DropSubscriptionStmt *stmt)`
`546`	`546`	`errdetail("The error was: %s",err)));`
`547`	`547`
`548`	`548`	`if (!walrcv_command(wrconn,cmd.data,&err))`
	`549`	`+{`
	`550`	`+/* Close the connection in case of failure */`
	`551`	`+walrcv_disconnect(wrconn);`
`549`	`552`	`ereport(ERROR,`
`550`	`553`	`(errmsg("could not drop the replication slot \"%s\" on publisher",`
`551`	`554`	`slotname),`
`552`	`555`	`errdetail("The error was: %s",err)));`
	`556`	`+}`
`553`	`557`	`else`
`554`	`558`	`ereport(NOTICE,`
`555`	`559`	`(errmsg("dropped replication slot \"%s\" on publisher",`

Comments

(0)