Commit88a6ac9

committed

pg_dump: Add GCC noreturn attribute to appropriate functions

This is a small help to the compiler and static analyzers.

1 parent5ae88c6 commit88a6ac9Copy full SHA for 88a6ac9

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ extern void write_msg(const char modulename, const char fmt,...)`
`57`	`57`	`externvoidvwrite_msg(constcharmodulename,constcharfmt,va_listap)`
`58`	`58`	`__attribute__((format(PG_PRINTF_ATTRIBUTE,2,0)));`
`59`	`59`	`externvoidexit_horribly(constcharmodulename,constcharfmt,...)`
`60`		`-__attribute__((format(PG_PRINTF_ATTRIBUTE,2,3)));`
	`60`	`+__attribute__((format(PG_PRINTF_ATTRIBUTE,2,3),noreturn));`
`61`	`61`	`externvoidset_section (constchararg,intdumpSections);`
`62`	`62`
`63`	`63`	`#endif/* DUMPUTILS_H */`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ static intRestoringToDB(ArchiveHandle *AH);`
`123`	`123`	`staticvoiddump_lo_buf(ArchiveHandle*AH);`
`124`	`124`	`staticvoidvdie_horribly(ArchiveHandleAH,constcharmodulename,`
`125`	`125`	`constchar*fmt,va_listap)`
`126`		`-__attribute__((format(PG_PRINTF_ATTRIBUTE,3,0)));`
	`126`	`+__attribute__((format(PG_PRINTF_ATTRIBUTE,3,0),noreturn));`
`127`	`127`
`128`	`128`	`staticvoiddumpTimestamp(ArchiveHandleAH,constcharmsg,time_ttim);`
`129`	`129`	`staticvoidSetOutput(ArchiveHandleAH,charfilename,intcompression);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ typedef struct _tocEntry`
`325`	`325`	`}TocEntry;`
`326`	`326`
`327`	`327`
`328`		`-externvoiddie_horribly(ArchiveHandleAH,constcharmodulename,constchar*fmt,...) __attribute__((format(PG_PRINTF_ATTRIBUTE,3,4)));`
	`328`	`+externvoiddie_horribly(ArchiveHandleAH,constcharmodulename,constchar*fmt,...) __attribute__((format(PG_PRINTF_ATTRIBUTE,3,4),noreturn));`
`329`	`329`	`externvoidwarn_or_die_horribly(ArchiveHandleAH,constcharmodulename,constchar*fmt,...) __attribute__((format(PG_PRINTF_ATTRIBUTE,3,4)));`
`330`	`330`
`331`	`331`	`externvoidWriteTOC(ArchiveHandle*AH);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,7 @@ extern void simple_string_list_append(SimpleStringList list, const char val);`
`524`	`524`	`externboolsimple_oid_list_member(SimpleOidList*list,Oidval);`
`525`	`525`	`externboolsimple_string_list_member(SimpleStringListlist,constcharval);`
`526`	`526`
`527`		`-externvoidexit_nicely(void);`
	`527`	`+externvoidexit_nicely(void) __attribute__((noreturn));`
`528`	`528`
`529`	`529`	`externvoidparseOidArray(constcharstr,Oidarray,intarraysize);`
`530`	`530`

Comments

(0)