NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit88047e5

committed

Fix an error when a set-returning function fails halfway through the execution

If the function using yield to return rows fails halfway, the iteratorstays open and subsequent calls to the function will resume readingfrom it. The fix is to unref the iterator and set it to NULL if therehas been an error.Jan Urbański

1 parent8995440 commit88047e5Copy full SHA for 88047e5

File tree

1 file changed

-0

lines changed

src/pl/plpython
- plpython.c

1 file changed

-0

lines changed

`‎src/pl/plpython/plpython.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1164,6 +1164,14 @@ PLy_function_handler(FunctionCallInfo fcinfo, PLyProcedure *proc)`
`1164`	`1164`	`Py_XDECREF(plargs);`
`1165`	`1165`	`Py_XDECREF(plrv);`
`1166`	`1166`
	`1167`	`+/*`
	`1168`	`+ * If there was an error the iterator might have not been exhausted`
	`1169`	`+ * yet. Set it to NULL so the next invocation of the function will`
	`1170`	`+ * start the iteration again.`
	`1171`	`+ */`
	`1172`	`+Py_XDECREF(proc->setof);`
	`1173`	`+proc->setof=NULL;`
	`1174`	`+`
`1167`	`1175`	`PG_RE_THROW();`
`1168`	`1176`	`}`
`1169`	`1177`	`PG_END_TRY();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit88047e5

File tree

1 file changed

1 file changed

`‎src/pl/plpython/plpython.c`

0 commit comments