NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit87a3023

committed

Move memory barrier in UnlockBufHdr to before releasing the lock.

This bug appears to have been introduced late in the development of4835458 ("Allow Pin/UnpinBuffer to operate in a lockfreemanner.").Found while debugging a bug which turned out to be independent of thecommit mentioned above.Backpatch: -

1 parent975ad4e commit87a3023Copy full SHA for 87a3023

File tree

1 file changed

-1

lines changed

src/include/storage
- buf_internals.h

1 file changed

-1

lines changed

`‎src/include/storage/buf_internals.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -242,8 +242,8 @@ extern PGDLLIMPORT LWLockMinimallyPadded *BufferIOLWLockArray;`
`242`	`242`	`externuint32LockBufHdr(BufferDesc*desc);`
`243`	`243`	`#defineUnlockBufHdr(desc,s)\`
`244`	`244`	`do {\`
`245`		`-pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \`
`246`	`245`	`pg_write_barrier(); \`
	`246`	`+pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \`
`247`	`247`	`} while (0)`
`248`	`248`
`249`	`249`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit87a3023

File tree

1 file changed

1 file changed

`‎src/include/storage/buf_internals.h`

0 commit comments