NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8776c15

committed

Fix incorrect tlist generation in create_gather_plan().

This function is written as though Gather doesn't project; but it does.Even if it did not project, though, we must use build_path_tlist to ensurethat the output columns receive correct sortgroupref labeling.Per report from Amit Kapila.

1 parentaa09cd2 commit8776c15Copy full SHA for 8776c15

File tree

1 file changed

-2

lines changed

src/backend/optimizer/plan
- createplan.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/plan/createplan.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1360,11 +1360,17 @@ create_gather_plan(PlannerInfo root, GatherPath best_path)`
`1360`	`1360`	`{`
`1361`	`1361`	`Gather*gather_plan;`
`1362`	`1362`	`Plan*subplan;`
	`1363`	`+List*tlist;`
`1363`	`1364`
`1364`		`-/* Must insist that all children return the same tlist */`
	`1365`	`+/*`
	`1366`	`+ * Although the Gather node can project, we prefer to push down such work`
	`1367`	`+ * to its child node, so demand an exact tlist from the child.`
	`1368`	`+ */`
`1365`	`1369`	`subplan=create_plan_recurse(root,best_path->subpath,CP_EXACT_TLIST);`
`1366`	`1370`
`1367`		`-gather_plan=make_gather(subplan->targetlist,`
	`1371`	`+tlist=build_path_tlist(root,&best_path->path);`
	`1372`	`+`
	`1373`	`+gather_plan=make_gather(tlist,`
`1368`	`1374`	`NIL,`
`1369`	`1375`	`best_path->path.parallel_degree,`
`1370`	`1376`	`best_path->single_copy,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8776c15

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/createplan.c`

0 commit comments