Commit84725aa

committed

Mark vacuum_defer_cleanup_age as PGC_POSTMASTER.

Following bug analysis of #7819 by Tom Lane

1 parente8ae019 commit84725aaCopy full SHA for 84725aa

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2356,8 +2356,7 @@ include 'filename'`
`2356`	`2356`	`is measured in terms of number of write transactions occurring on the`
`2357`	`2357`	`primary server, it is difficult to predict just how much additional`
`2358`	`2358`	`grace time will be made available to standby queries.`
`2359`		`- This parameter can only be set in the <filename>postgresql.conf</>`
`2360`		`- file or on the server command line.`
	`2359`	`+ This parameter can only be set at server start.`
`2361`	`2360`	`</para>`
`2362`	`2361`	`<para>`
`2363`	`2362`	`You should also consider setting <varname>hot_standby_feedback</>`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1881,7 +1881,12 @@ static struct config_int ConfigureNamesInt[] =`
`1881`	`1881`	`},`
`1882`	`1882`
`1883`	`1883`	`{`
`1884`		`-{"vacuum_defer_cleanup_age",PGC_SIGHUP,REPLICATION_MASTER,`
	`1884`	`+/*`
	`1885`	`+ * Setting this to a higher value without restarting postmaster`
	`1886`	`+ * can cause various bugs in TOAST object removal, CLUSTER and`
	`1887`	`+ * possibly other places, so this must be changed only on restart.`
	`1888`	`+ */`
	`1889`	`+{"vacuum_defer_cleanup_age",PGC_POSTMASTER,REPLICATION_MASTER,`
`1885`	`1890`	`gettext_noop("Number of transactions by which VACUUM and HOT cleanup should be deferred, if any."),`
`1886`	`1891`	`NULL`
`1887`	`1892`	`},`

Comments

(0)