Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit843657b

Browse files
committed
attached is take-2 of a patch which fixes a bug related
to the use of getpwuid when running in standalone mode.this patch allocates some persistent storage (usingstrdup) to store the username obtained with getpwuidin src/backend/main/main.c. this is necessary becauselater on, getpwuid is called again (in ValidateBinary).the man pages for getpwuid on SCO OpenServer, FreeBSD,and Darwin all have words to this effect (this is fromthe SCO OpenServer man page): Note ==== All information is contained in a static area, so it must be copied if it is to be saved. Otherwise, it may be overwritten on subsequent calls to these routines.in particular, on my platform, the storage used to holdthe pw_name from the first call is overwritten such thatit looks like an empty username. this causes a problemlater on in SetSessionUserIdFromUserName.i'd assume this isn't a problem on most platforms becausegetpwuid is called with the same UID both times, and thesame thing ends up happening to that static storage eachtime. however, that's not guaranteed, and is _not_ whathappens on my platform (at least :).this is for the version of 7.1 available via anon cvs asof Tue Jan 23 15:14:00 2001 PST: .../src/backend/main/main.c,v 1.37 2000/12/31 18:04:35 tgl Exp-michael thornburgh, zenomt@armory.com
1 parentcb5427e commit843657b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎src/backend/main/main.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*
1414
*
1515
* IDENTIFICATION
16-
* $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.37 2000/12/31 18:04:35 tgl Exp $
16+
* $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.38 2001/01/24 03:50:06 momjian Exp $
1717
*
1818
*-------------------------------------------------------------------------
1919
*/
@@ -53,6 +53,7 @@ main(int argc, char *argv[])
5353
{
5454
intlen;
5555
structpasswd*pw;
56+
char*pw_name_persist;
5657

5758
/*
5859
* Place platform-specific startup hacks here. This is the right
@@ -158,6 +159,7 @@ main(int argc, char *argv[])
158159
fprintf(stderr,"%s: invalid current euid",argv[0]);
159160
exit(1);
160161
}
162+
pw_name_persist=strdup(pw->pw_name);
161163

162-
exit(PostgresMain(argc,argv,argc,argv,pw->pw_name));
164+
exit(PostgresMain(argc,argv,argc,argv,pw_name_persist));
163165
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp