Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit83aaebb

Browse files
committed
Fix incorrect comment about the timing of AbsorbFsyncRequests() during
checkpoint. The comment claimed that we could do this anytime aftersetting the checkpoint REDO point, but actually BufferSync is relyingon the assumption that buffers dumped by other backends will be fsync'dtoo. So we really could not do it any sooner than we are doing it.
1 parenta558981 commit83aaebb

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

‎src/backend/postmaster/bgwriter.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
*
3939
* IDENTIFICATION
40-
* $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.40 2007/06/30 19:12:01 tgl Exp $
40+
* $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.41 2007/07/03 14:51:24 tgl Exp $
4141
*
4242
*-------------------------------------------------------------------------
4343
*/
@@ -1007,9 +1007,9 @@ ForwardFsyncRequest(RelFileNode rnode, BlockNumber segno)
10071007
*Retrieve queued fsync requests and pass them to local smgr.
10081008
*
10091009
* This is exported because it must be called during CreateCheckPoint;
1010-
* we have to be sure we have accepted all pending requests*after* we
1011-
*establish the checkpoint REDO pointer. Since CreateCheckPoint
1012-
*sometimes runs innon-bgwriter processes, do nothing if not bgwriter.
1010+
* we have to be sure we have accepted all pending requestsjust before
1011+
*we start fsync'ing. Since CreateCheckPoint sometimes runs in
1012+
* non-bgwriter processes, do nothing if not bgwriter.
10131013
*/
10141014
void
10151015
AbsorbFsyncRequests(void)

‎src/backend/storage/smgr/md.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/storage/smgr/md.c,v 1.128 2007/04/12 17:10:55 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/storage/smgr/md.c,v 1.129 2007/07/03 14:51:24 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -880,9 +880,12 @@ mdsync(void)
880880

881881
/*
882882
* If we are in the bgwriter, the sync had better include all fsync
883-
* requests that were queued by backends before the checkpoint REDO
884-
* point was determined. We go that a little better by accepting all
885-
* requests queued up to the point where we start fsync'ing.
883+
* requests that were queued by backends up to this point. The tightest
884+
* race condition that could occur is that a buffer that must be written
885+
* and fsync'd for the checkpoint could have been dumped by a backend
886+
* just before it was visited by BufferSync(). We know the backend will
887+
* have queued an fsync request before clearing the buffer's dirtybit,
888+
* so we are safe as long as we do an Absorb after completing BufferSync().
886889
*/
887890
AbsorbFsyncRequests();
888891

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp