NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8359ed8

committed

Improve handling of pthread_mutex_lock error case

We should really be reporting a useful error along with returninga valid return code if pthread_mutex_lock() throws an error forsome reason. Add that and back-patch to 9.0 as the prior patch.Pointed out by Alvaro Herrera

1 parentf31c149 commit8359ed8Copy full SHA for 8359ed8

File tree

1 file changed

+13

-1

lines changed

src/interfaces/libpq
- fe-secure.c

1 file changed

+13

-1

lines changed

`‎src/interfaces/libpq/fe-secure.c`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,11 @@ pqsecure_open_client(PGconn *conn)`
`261`	`261`
`262`	`262`	`#ifdefENABLE_THREAD_SAFETY`
`263`	`263`	`if (pthread_mutex_lock(&ssl_config_mutex))`
`264`		`-return-1;`
	`264`	`+{`
	`265`	`+printfPQExpBuffer(&conn->errorMessage,`
	`266`	`+libpq_gettext("unable to acquire mutex\n"));`
	`267`	`+returnPGRES_POLLING_FAILED;`
	`268`	`+}`
`265`	`269`	`#endif`
`266`	`270`	`/* Create a connection-specific SSL object */`
`267`	`271`	`if (!(conn->ssl=SSL_new(SSL_context))\|\|`
`@@ -1112,7 +1116,11 @@ initialize_SSL(PGconn *conn)`
`1112`	`1116`	`*/`
`1113`	`1117`	`#ifdefENABLE_THREAD_SAFETY`
`1114`	`1118`	`if (pthread_mutex_lock(&ssl_config_mutex))`
	`1119`	`+{`
	`1120`	`+printfPQExpBuffer(&conn->errorMessage,`
	`1121`	`+libpq_gettext("unable to acquire mutex\n"));`
`1115`	`1122`	`return-1;`
	`1123`	`+}`
`1116`	`1124`	`#endif`
`1117`	`1125`	`if (SSL_CTX_use_certificate_chain_file(SSL_context,fnbuf)!=1)`
`1118`	`1126`	`{`
`@@ -1326,7 +1334,11 @@ initialize_SSL(PGconn *conn)`
`1326`	`1334`
`1327`	`1335`	`#ifdefENABLE_THREAD_SAFETY`
`1328`	`1336`	`if (pthread_mutex_lock(&ssl_config_mutex))`
	`1337`	`+{`
	`1338`	`+printfPQExpBuffer(&conn->errorMessage,`
	`1339`	`+libpq_gettext("unable to acquire mutex\n"));`
`1329`	`1340`	`return-1;`
	`1341`	`+}`
`1330`	`1342`	`#endif`
`1331`	`1343`	`if (SSL_CTX_load_verify_locations(SSL_context,fnbuf,NULL)!=1)`
`1332`	`1344`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8359ed8

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-secure.c`

0 commit comments