NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit815a31c

committed

Fix wrong keysize in PrivateRefCountHash creation.

In4b4b680 I accidentally used sizeof(PrivateRefCountArray) instead ofsizeof(PrivateRefCountEntry) when creating the refcount overflowhashtable. As the former is bigger than the latter, this luckily onlyresulted in a slightly increased memory usage when many buffers arepinned in a backend.Reported-By: Takashi HorikawaDiscussion: 73FA3881462C614096F815F75628AFCD035A48C3@BPXM01GP.gisp.nec.co.jpBackpatch: 9.5, where thew new ref count infrastructure was introduced

1 parent68d68ff commit815a31cCopy full SHA for 815a31c

File tree

1 file changed

-1

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-1

lines changed

`‎src/backend/storage/buffer/bufmgr.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2103,7 +2103,7 @@ InitBufferPoolAccess(void)`
`2103`	`2103`
`2104`	`2104`	`MemSet(&hash_ctl,0,sizeof(hash_ctl));`
`2105`	`2105`	`hash_ctl.keysize=sizeof(int32);`
`2106`		`-hash_ctl.entrysize=sizeof(PrivateRefCountArray);`
	`2106`	`+hash_ctl.entrysize=sizeof(PrivateRefCountEntry);`
`2107`	`2107`
`2108`	`2108`	`PrivateRefCountHash=hash_create("PrivateRefCount",100,&hash_ctl,`
`2109`	`2109`	`HASH_ELEM \|HASH_BLOBS);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit815a31c

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c‎`

0 commit comments