NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit80727ce

committed

Use stat(2) to probe for existing xlog segments in InstallXLogFileSegment,

rather than actually opening the files. This eliminates some corner caseswhere the file indeed exists but open() fails for another reason, suchas being out of file descriptors. The net reliability gain is probablytiny, since xlog.c is full of other file open calls that will elog(PANIC)if they fail for any reason; but this specific failure mode has beenobserved in the field, so we may as well fix it.

1 parent7a196ba commit80727ceCopy full SHA for 80727ce

File tree

1 file changed

-5

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-5

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.110 2002/11/08 20:23:56 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.111 2003/01/25 03:06:04 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1471,7 +1471,7 @@ InstallXLogFileSegment(uint32 log, uint32 seg, char *tmppath,`
`1471`	`1471`	`booluse_lock)`
`1472`	`1472`	`{`
`1473`	`1473`	`charpath[MAXPGPATH];`
`1474`		`-intfd;`
	`1474`	`+structstatstat_buf;`
`1475`	`1475`
`1476`	`1476`	`XLogFileName(path,log,seg);`
`1477`	`1477`
`@@ -1489,10 +1489,8 @@ InstallXLogFileSegment(uint32 log, uint32 seg, char *tmppath,`
`1489`	`1489`	`else`
`1490`	`1490`	`{`
`1491`	`1491`	`/* Find a free slot to put it in */`
`1492`		`-while ((fd=BasicOpenFile(path,O_RDWR \|PG_BINARY,`
`1493`		`-S_IRUSR \|S_IWUSR)) >=0)`
	`1492`	`+while (stat(path,&stat_buf)==0)`
`1494`	`1493`	`{`
`1495`		`-close(fd);`
`1496`	`1494`	`if (--max_advance<0)`
`1497`	`1495`	`{`
`1498`	`1496`	`/* Failed to find a free slot within specified range */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit80727ce

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments