NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit804f016

committed

Fix outfuncs.c to dump A_Const nodes representing NULLs correctly. This has

been broken since forever, but was not noticed because people seldom lookat raw parse trees. AFAIK, no impact on users except that debug_print_parsemight fail; but patch it all the way back anyway. Per report from Jeff Ross.

1 parent74fbe9c commit804f016Copy full SHA for 804f016

File tree

1 file changed

-1

lines changed

src/backend/nodes
- outfuncs.c

1 file changed

-1

lines changed

`‎src/backend/nodes/outfuncs.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.311 2007/06/11 22:22:40 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.312 2007/07/17 01:21:43 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* Every node type that can appear in stored rules' parsetrees must`
`@@ -1900,6 +1900,10 @@ _outValue(StringInfo str, Value *value)`
`1900`	`1900`	`/* internal representation already has leading 'b' */`
`1901`	`1901`	`appendStringInfoString(str,value->val.str);`
`1902`	`1902`	`break;`
	`1903`	`+caseT_Null:`
	`1904`	`+/* this is seen only within A_Const, not in transformed trees */`
	`1905`	`+appendStringInfoString(str,"NULL");`
	`1906`	`+break;`
`1903`	`1907`	`default:`
`1904`	`1908`	`elog(ERROR,"unrecognized node type: %d", (int)value->type);`
`1905`	`1909`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit804f016

File tree

1 file changed

1 file changed

`‎src/backend/nodes/outfuncs.c`

0 commit comments