NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit8023b58

committed

Remove nearly-unused SizeOfIptrData macro.

Past refactorings have removed all but one reference to SizeOfIptrData(and that one place was in a pretty noncritical spot). Since nobody'scomplained, it seems probable that there are no supported compilersthat don't think sizeof(ItemPointerData) is 6. If there are, we'rewasting MAXALIGN per heap tuple anyway, so it's rather silly to worryabout whether we can shave space in places like WAL records.Pavan DeolaseeDiscussion: <CABOikdOOawDda4hwLOT6zdA6MFfPLu3Z2YBZkX0JdayNS6JOeQ@mail.gmail.com>

1 parent96dd77d commit8023b58Copy full SHA for 8023b58

File tree

2 files changed

-7

lines changed

src
- backend/executor
  - nodeTidscan.c
- include/storage
  - itemptr.h

2 files changed

-7

lines changed

`‎src/backend/executor/nodeTidscan.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ TidListCreate(TidScanState *tidstate)`
`139`	`139`	`continue;`
`140`	`140`	`itemarray=DatumGetArrayTypeP(arraydatum);`
`141`	`141`	`deconstruct_array(itemarray,`
`142`		`-TIDOID,SizeOfIptrData, false,'s',`
	`142`	`+TIDOID,sizeof(ItemPointerData), false,'s',`
`143`	`143`	`&ipdatums,&ipnulls,&ndatums);`
`144`	`144`	`if (numTids+ndatums>numAllocTids)`
`145`	`145`	`{`

`‎src/include/storage/itemptr.h`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,8 @@`
`30`	`30`	`* structure padding bytes. The struct is designed to be six bytes long`
`31`	`31`	`* (it contains three int16 fields) but a few compilers will pad it to`
`32`	`32`	`* eight bytes unless coerced. We apply appropriate persuasion where`
`33`		`- * possible, and to cope with unpersuadable compilers, we try to use`
`34`		`- * "SizeOfIptrData" rather than "sizeof(ItemPointerData)" when computing`
`35`		`- * on-disk sizes.`
	`33`	`+ * possible. If your compiler can't be made to play along, you'll waste`
	`34`	`+ * lots of space.`
`36`	`35`	`*/`
`37`	`36`	`typedefstructItemPointerData`
`38`	`37`	`{`
`@@ -46,9 +45,6 @@ pg_attribute_aligned(2)`
`46`	`45`	`#endif`
`47`	`46`	`ItemPointerData;`
`48`	`47`
`49`		`-#defineSizeOfIptrData\`
`50`		`-(offsetof(ItemPointerData, ip_posid) + sizeof(OffsetNumber))`
`51`		`-`
`52`	`48`	`typedefItemPointerData*ItemPointer;`
`53`	`49`
`54`	`50`	`/* ----------------`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8023b58

File tree

2 files changed

2 files changed

`‎src/backend/executor/nodeTidscan.c`

`‎src/include/storage/itemptr.h`

0 commit comments