NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit7ea9b99

committed

Remove unnecessary coziness of GIN code with datum copying. Now that

space is tracked via GetMemoryChunkSpace, there's really no advantageto duplicating datumCopy's innards here. This is one bit of my toastindirection patch that should go in anyway.

1 parent4a8d573 commit7ea9b99Copy full SHA for 7ea9b99

File tree

1 file changed

-13

lines changed

src/backend/access/gin
- ginbulk.c

1 file changed

-13

lines changed

`‎src/backend/access/gin/ginbulk.c`

Lines changed: 5 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- *$PostgreSQL: pgsql/src/backend/access/gin/ginbulk.c,v 1.11 2008/01/01 19:45:46 momjian Exp $`
	`11`	`+ *$PostgreSQL: pgsql/src/backend/access/gin/ginbulk.c,v 1.12 2008/06/29 21:04:01 tgl Exp $`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`14`	`14`
`@@ -78,8 +78,8 @@ ginInsertData(BuildAccumulator accum, EntryAccumulator entry, ItemPointer heap`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`/*`
`81`		`- * This is basically the same as datumCopy(), butwe duplicate some code`
`82`		`- *to avoid computing the datum size twice.`
	`81`	`+ * This is basically the same as datumCopy(), butmodified to count`
	`82`	`+ *palloc'd space in accum.`
`83`	`83`	`*/`
`84`	`84`	`staticDatum`
`85`	`85`	`getDatumCopy(BuildAccumulator*accum,Datumvalue)`
`@@ -91,16 +91,8 @@ getDatumCopy(BuildAccumulator *accum, Datum value)`
`91`	`91`	`res=value;`
`92`	`92`	`else`
`93`	`93`	`{`
`94`		`-SizerealSize;`
`95`		`-char*s;`
`96`		`-`
`97`		`-realSize=datumGetSize(value, false,att[0]->attlen);`
`98`		`-`
`99`		`-s= (char*)palloc(realSize);`
`100`		`-accum->allocatedMemory+=GetMemoryChunkSpace(s);`
`101`		`-`
`102`		`-memcpy(s,DatumGetPointer(value),realSize);`
`103`		`-res=PointerGetDatum(s);`
	`94`	`+res=datumCopy(value, false,att[0]->attlen);`
	`95`	`+accum->allocatedMemory+=GetMemoryChunkSpace(DatumGetPointer(res));`
`104`	`96`	`}`
`105`	`97`	`returnres;`
`106`	`98`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7ea9b99

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginbulk.c`

0 commit comments