Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit7cd30e1

Browse files
committed
TestConfiguration returns int, not bool. This mistake is relatively
harmless on signed-char machines but would lead to core dump in thedeadlock detection code if char is unsigned. Amazingly, this bug hasbeen here since 7.1 and yet wasn't reported till now. Thanks to RobertBruccoleri for providing the opportunity to track it down.
1 parent80597fd commit7cd30e1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

‎src/backend/storage/lmgr/deadlock.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*
1313
*
1414
* IDENTIFICATION
15-
* $Header: /cvsroot/pgsql/src/backend/storage/lmgr/deadlock.c,v 1.19 2003/02/19 23:41:15 momjian Exp $
15+
* $Header: /cvsroot/pgsql/src/backend/storage/lmgr/deadlock.c,v 1.20 2003/03/31 20:32:29 tgl Exp $
1616
*
1717
*Interface:
1818
*
@@ -64,7 +64,7 @@ typedef struct
6464

6565

6666
staticboolDeadLockCheckRecurse(PGPROC*proc);
67-
staticboolTestConfiguration(PGPROC*startProc);
67+
staticintTestConfiguration(PGPROC*startProc);
6868
staticboolFindLockCycle(PGPROC*checkProc,
6969
EDGE*softEdges,int*nSoftEdges);
7070
staticboolFindLockCycleRecurse(PGPROC*checkProc,intdepth,
@@ -338,7 +338,7 @@ DeadLockCheckRecurse(PGPROC *proc)
338338
* number of soft edges.
339339
*--------------------
340340
*/
341-
staticbool
341+
staticint
342342
TestConfiguration(PGPROC*startProc)
343343
{
344344
intsoftFound=0;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp