NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit77c7507

committed

Fix oversight in new EvalPlanQual logic: the second loop over the ExecRowMark

list in ExecLockRows() forgot to allow for the possibility that some of therowmarks are for child tables that aren't relevant to the current row.Per report from Kenichiro Tanaka.

1 parent2dbbda0 commit77c7507Copy full SHA for 77c7507

File tree

1 file changed

-1

lines changed

src/backend/executor
- nodeLockRows.c

1 file changed

-1

lines changed

`‎src/backend/executor/nodeLockRows.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/executor/nodeLockRows.c,v 1.5 2010/07/12 17:01:05 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/executor/nodeLockRows.c,v 1.6 2010/07/28 17:21:56 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -195,6 +195,13 @@ ExecLockRows(LockRowsState *node)`
`195`	`195`	`HeapTupleDatatuple;`
`196`	`196`	`Bufferbuffer;`
`197`	`197`
	`198`	`+/* ignore non-active child tables */`
	`199`	`+if (!ItemPointerIsValid(&(erm->curCtid)))`
	`200`	`+{`
	`201`	`+Assert(erm->rti!=erm->prti);/* check it's child table */`
	`202`	`+continue;`
	`203`	`+}`
	`204`	`+`
`198`	`205`	`if (EvalPlanQualGetTuple(&node->lr_epqstate,erm->rti)!=NULL)`
`199`	`206`	`continue;/* it was updated and fetched above */`
`200`	`207`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit77c7507

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeLockRows.c`

0 commit comments