Commit77a436b

committed

Fix seriously nasty memory leak in new TransactionIdIsInProgress code.

1 parent573a71a commit77a436bCopy full SHA for 77a436b

File tree

-4

lines changed

-4

lines changed

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.65 2004/07/0100:50:52 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.66 2004/07/0103:13:05 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -509,7 +509,6 @@ TransactionIdIsInProgress(TransactionId xid)`
`509`	`509`
`510`	`510`	`if (result)`
`511`	`511`	`break;`
`512`		`-`
`513`	`512`	`}`
`514`	`513`	`}`
`515`	`514`
`@@ -531,12 +530,18 @@ TransactionIdIsInProgress(TransactionId xid)`
`531`	`530`	`* We don't care if it aborted, because if it did, we won't find`
`532`	`531`	`* it in the array.`
`533`	`532`	`*/`
`534`		`-`
`535`	`533`	`for (i=0;i<nxids;i++)`
	`534`	`+{`
`536`	`535`	`if (TransactionIdEquals(xids[i],xid))`
`537`		`-return true;`
	`536`	`+{`
	`537`	`+result= true;`
	`538`	`+break;`
	`539`	`+}`
	`540`	`+}`
`538`	`541`	`}`
`539`	`542`
	`543`	`+pfree(xids);`
	`544`	`+`
`540`	`545`	`returnresult;`
`541`	`546`	`}`
`542`	`547`

Comments

(0)